Skip to content

refactor: remove the ability to customize node_modules path #2202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2025
Merged

refactor: remove the ability to customize node_modules path #2202

merged 2 commits into from
Nov 11, 2025
+3,090 −3,249

Conversation

@jbedard
Copy link
Member

@jbedard jbedard commented Apr 25, 2025 •
edited
Loading

Close #2196

Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): yes
  • Suggested release notes appear below: yes

Remove the ability to customize the "node_modules" name in rules such as npm_link_all_packages.

Test plan

  • Covered by existing test cases

@aspect-workflows
Copy link

aspect-workflows bot commented Apr 25, 2025 •
edited
Loading

Bazel 7 (Test)

Buildkite build #10456 is running...

Bazel 8 (Test)

2 test targets passed

Targets 
//npm/private:_test_gendocs_0_0 [k8-fastbuild] 45ms
//npm/private:_test_gendocs_0_1 [k8-fastbuild] 185ms

Total test execution time was 230ms. 252 tests (99.2%) were fully cached saving 34s.

Bazel 7 (Test)

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 562ms.

Bazel 7 (Test)

e2e/git_dep_metadata

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Bazel 7 (Test)

e2e/gyp_no_install_script

1 test target passed

Targets 
//:write_npm_translate_lock_bzlmod_test [k8-fastbuild]            111ms

Total test execution time was 111ms. 1 test (50.0%) was fully cached saving 98ms.

Bazel 7 (Test)

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 6s.

Bazel 7 (Test)

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 291ms.

Bazel 7 (Test)

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 220ms.

Bazel 7 (Test)

e2e/npm_link_package-rerooted

All tests were cache hits

2 tests (100.0%) were fully cached saving 276ms.

Bazel 7 (Test)

e2e/npm_translate_lock

All tests were cache hits

3 tests (100.0%) were fully cached saving 582ms.

Bazel 7 (Test)

e2e/npm_translate_lock_disable_hooks

All tests were cache hits

3 tests (100.0%) were fully cached saving 698ms.

Bazel 7 (Test)

e2e/npm_translate_lock_empty

1 test target passed

Targets 
//:write_npm_translate_lock_bzlmod_test [k8-fastbuild]            97ms

Total test execution time was 97ms. 1 test (50.0%) was fully cached saving 31ms.

Bazel 7 (Test)

e2e/npm_translate_lock_exclude_package_contents

All tests were cache hits

1 test (100.0%) was fully cached saving 34ms.

Bazel 7 (Test)

e2e/npm_translate_lock_link_workspace

Buildkite build #10456 is running...

Bazel 7 (Test)

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 164ms.

Bazel 7 (Test)

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 61ms.

Bazel 7 (Test)

e2e/npm_translate_lock_replace_packages

1 test target passed

Targets 
//:write_npm_translate_lock_bzlmod_test [k8-fastbuild]            120ms

Total test execution time was 120ms. 3 tests (75.0%) were fully cached saving 282ms.

Bazel 7 (Test)

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 105ms.

Bazel 7 (Test)

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Bazel 7 (Test)

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Bazel 7 (Test)

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 313ms.

Bazel 7 (Test)

e2e/patch_from_repo

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Bazel 7 (Test)

e2e/pnpm_lockfiles

All tests were cache hits

33 tests (100.0%) were fully cached saving 4s.

Bazel 7 (Test)

e2e/pnpm_repo_install

Buildkite build #10456 is running...

Bazel 7 (Test)

e2e/pnpm_version

All tests were cache hits

1 test (100.0%) was fully cached saving 89ms.

Bazel 7 (Test)

e2e/pnpm_workspace

All tests were cache hits

15 tests (100.0%) were fully cached saving 3s.

Bazel 7 (Test)

e2e/pnpm_workspace_deps

Buildkite build #10456 is running...

Bazel 7 (Test)

e2e/pnpm_workspace_rerooted

All tests were cache hits

15 tests (100.0%) were fully cached saving 2s.

Bazel 7 (Test)

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 454ms.

Bazel 7 (Test)

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 118ms.

Bazel 7 (Test)

e2e/stamped_package_json

All tests were cache hits

1 test (100.0%) was fully cached saving 44ms.

Bazel 7 (Test)

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 78ms.

Bazel 7 (Test)

e2e/vendored_tarfile

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Bazel 7 (Test)

e2e/verify_patches

All tests were cache hits

2 tests (100.0%) were fully cached saving 109ms.

Bazel 7 (Test)

e2e/worker

All tests were cache hits

1 test (100.0%) was fully cached saving 35ms.

Buildifier      Format

@jbedard jbedard force-pushed the 2196-rm-the-node_modules branch from 8abf4c3 to cf54f5a Compare April 25, 2025 07:48
@jbedard jbedard requested a review from dzbarsky April 25, 2025 07:49
@jbedard jbedard force-pushed the 2196-rm-the-node_modules branch 2 times, most recently from 5102c89 to 935d9c2 Compare April 28, 2025 17:46
dzbarsky
dzbarsky reviewed Apr 28, 2025
View reviewed changes
dzbarsky
dzbarsky reviewed Apr 28, 2025
View reviewed changes
dzbarsky
dzbarsky approved these changes Apr 28, 2025
View reviewed changes
Copy link
Collaborator

@dzbarsky dzbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love this

jbedard
jbedard commented Apr 29, 2025
View reviewed changes
@jbedard jbedard force-pushed the 2196-rm-the-node_modules branch 2 times, most recently from 2be2231 to f0c9856 Compare May 1, 2025 15:57
@jbedard jbedard force-pushed the 2196-rm-the-node_modules branch from f0c9856 to 5a66888 Compare June 25, 2025 04:10
@jbedard jbedard mentioned this pull request Aug 5, 2025
Merged
@jbedard jbedard added the breaking Requires a semver-major release due to breaking public API changes label Aug 5, 2025
@jbedard jbedard force-pushed the 2196-rm-the-node_modules branch from 5a66888 to cd8860a Compare August 22, 2025 18:02
@jbedard jbedard force-pushed the 2196-rm-the-node_modules branch 2 times, most recently from f72a38a to 7fe53cc Compare September 23, 2025 22:48
@jbedard jbedard force-pushed the 2196-rm-the-node_modules branch 3 times, most recently from abec744 to 8e6784d Compare November 11, 2025 07:14
@jbedard jbedard changed the base branch from main to 3.x November 11, 2025 07:14
@jbedard jbedard changed the title feat: remove the ability to customize node_modules path refactor: remove the ability to customize node_modules path Nov 11, 2025
@jbedard jbedard force-pushed the 2196-rm-the-node_modules branch 3 times, most recently from 2fe0729 to 0c11f7f Compare November 11, 2025 07:39
@jbedard jbedard marked this pull request as ready for review November 11, 2025 07:41
@jbedard jbedard force-pushed the 2196-rm-the-node_modules branch from 0c11f7f to c32411c Compare November 11, 2025 08:39
@jbedard jbedard mentioned this pull request Nov 11, 2025
Open
18 tasks
@jbedard jbedard force-pushed the 2196-rm-the-node_modules branch from c32411c to 98f1ce8 Compare November 11, 2025 09:26
@jbedard jbedard force-pushed the 2196-rm-the-node_modules branch from 98f1ce8 to 1463aa5 Compare November 11, 2025 09:31
@jbedard jbedard merged commit 84b62f5 into aspect-build:3.x Nov 11, 2025
42 of 43 checks passed
@jbedard jbedard deleted the 2196-rm-the-node_modules branch November 11, 2025 09:36
@jbedard jbedard mentioned this pull request Nov 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzbarsky dzbarsky dzbarsky approved these changes

Assignees

No one assigned

Labels

breaking Requires a semver-major release due to breaking public API changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove ability to customize virtual store name

2 participants

@jbedard @dzbarsky